Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

unitALG
Copy link
Contributor

@unitALG unitALG commented Sep 18, 2025

Description

I included a number of small fixes from several Jira feedback tickets:

  • DOCATT-8541: Added clarification to the example comments in InputInteractionContext.SetTimeout that Started() needs to be called before SetTimeout(), as requested via user feedback.
  • DOCATT-8611: Filtered out the docs for the internal platformUserAccountXXX properties and the FindUserByAccount method on the InputUser struct. These were not documented, but DocFx still generates empty documentation for them unless they are explicitly filtered out.
  • DOCATT-8610: Clarified that disabling the action can result when DisableJoining is called on an action that was joined with the JoinPlayersWhenJoinActionIsTriggered behavior, as discussed with @ritamerkl on the input-team channel. Also added doc for JoinPlayersWhenJoinActionIsTriggered value itself.
  • DOCATT-8558: Updated the RebindingOperation class example with a local variable in OnClick(), as requested via user feedback.
  • DOCATT-8557: Removed sentence in samplingFrequency with QuerySamplingFrequencyCommand link because it is internal and shouldn't be exposed, as discussed with @ritamerkl on the input-team channel.

Testing status & QA

  • Generated documentation locally to confirm changes.

Overall Product Risks

Very low risk: documentation changes only.

Comments to reviewers

I added the 3 reviewers who contributed the last time. Please let me know if I am missing anyone.

Checklist

Before review:

  • I didn't add a changelog entry since the fixes were fairly minor, but I wasn't sure whether I should have added one for removing the user handle properties and the method. Please let me know if you would prefer me to add one.
  • No Tests added/changed (not applicable).

During merge:

  • Commit message for squash-merge is prefixed with DOCS: ___

After merge:

  • No forward/backward port needed.

@codecov-github-com
Copy link

codecov-github-com bot commented Sep 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2240      +/-   ##
===========================================
+ Coverage    68.14%   76.70%   +8.56%     
===========================================
  Files          367      465      +98     
  Lines        53685    87919   +34234     
===========================================
+ Hits         36584    67442   +30858     
- Misses       17101    20477    +3376     
Flag Coverage Δ
inputsystem_MacOS_2021.3 5.91% <ø> (?)
inputsystem_MacOS_2021.3_project 78.05% <ø> (?)
inputsystem_MacOS_2022.3 5.37% <ø> (?)
inputsystem_MacOS_2022.3_project 74.58% <ø> (?)
inputsystem_MacOS_6000.0 5.19% <ø> (?)
inputsystem_MacOS_6000.0_project 76.50% <ø> (?)
inputsystem_MacOS_6000.2 5.19% <ø> (?)
inputsystem_MacOS_6000.2_project 76.51% <ø> (?)
inputsystem_MacOS_6000.3 5.19% <ø> (?)
inputsystem_MacOS_6000.3_project 76.50% <ø> (?)
inputsystem_MacOS_6000.4 5.19% <ø> (?)
inputsystem_MacOS_6000.4_project 76.50% <ø> (?)
inputsystem_Ubuntu_2021.3 5.91% <ø> (?)
inputsystem_Ubuntu_2021.3_project 77.96% <ø> (?)
inputsystem_Ubuntu_2022.3 5.38% <ø> (?)
inputsystem_Ubuntu_2022.3_project 74.39% <ø> (?)
inputsystem_Ubuntu_6000.0 5.19% <ø> (?)
inputsystem_Ubuntu_6000.0_project 76.32% <ø> (?)
inputsystem_Ubuntu_6000.2 5.19% <ø> (?)
inputsystem_Ubuntu_6000.2_project 76.32% <ø> (?)
inputsystem_Ubuntu_6000.3 5.19% <ø> (?)
inputsystem_Ubuntu_6000.3_project 76.31% <ø> (?)
inputsystem_Ubuntu_6000.4 5.19% <ø> (?)
inputsystem_Ubuntu_6000.4_project 76.31% <ø> (?)
inputsystem_Windows_2021.3 5.91% <ø> (?)
inputsystem_Windows_2021.3_project 78.20% <ø> (?)
inputsystem_Windows_2022.3 5.37% <ø> (?)
inputsystem_Windows_2022.3_project 74.72% <ø> (?)
inputsystem_Windows_6000.0 5.19% <ø> (?)
inputsystem_Windows_6000.0_project 76.64% <ø> (?)
inputsystem_Windows_6000.2 5.19% <ø> (?)
inputsystem_Windows_6000.2_project 76.64% <ø> (?)
inputsystem_Windows_6000.3 5.19% <ø> (?)
inputsystem_Windows_6000.3_project 76.64% <ø> (?)
inputsystem_Windows_6000.4 5.19% <ø> (?)
inputsystem_Windows_6000.4_project 76.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...utSystem/Actions/InputActionRebindingExtensions.cs 82.96% <ø> (ø)
...tem/InputSystem/Actions/InputInteractionContext.cs 67.21% <ø> (ø)
...om.unity.inputsystem/InputSystem/Devices/Sensor.cs 99.53% <ø> (ø)
...utSystem/Plugins/PlayerInput/PlayerInputManager.cs 70.69% <ø> (ø)
...inputsystem/InputSystem/Plugins/Users/InputUser.cs 86.98% <ø> (ø)

... and 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant