-
Notifications
You must be signed in to change notification settings - Fork 329
DOCS: DOCATT Quality Sprint batch fixes #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unitALG
wants to merge
8
commits into
develop
Choose a base branch
from
docatt-qsprint-batch-fixes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added doc for JoinPlayersWhenJoinActionIsTriggered value - Clarified that disabling the action can result when DisableJoining() is called on an action that was joined with the JoinPlayersWhenJoinActionIsTriggered behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I included a number of small fixes from several Jira feedback tickets:
Started()
needs to be called beforeSetTimeout()
, as requested via user feedback.platformUserAccountXXX
properties and theFindUserByAccount
method on the InputUser struct. These were not documented, but DocFx still generates empty documentation for them unless they are explicitly filtered out.JoinPlayersWhenJoinActionIsTriggered
behavior, as discussed with @ritamerkl on the input-team channel. Also added doc forJoinPlayersWhenJoinActionIsTriggered
value itself.OnClick()
, as requested via user feedback.Testing status & QA
Overall Product Risks
Very low risk: documentation changes only.
Comments to reviewers
I added the 3 reviewers who contributed the last time. Please let me know if I am missing anyone.
Checklist
Before review:
During merge:
DOCS: ___
After merge: