Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for Visual Studio 2022. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Add support for Visual Studio 2022. #14

merged 3 commits into from
Nov 29, 2021

Conversation

venkify
Copy link

@venkify venkify commented Nov 16, 2021

Added initial support for Visual Studio 2022.
Tested with recent trunk with both 2019 and 2022.

2 things that may need cleanup :

  1. Getting Visual Studio path seems a bit tricky. Used my local path for now.
  2. VSIX Manifest needs comment/uncomment depending on version building for.

@venkify venkify requested review from joncham and UnityAlex November 16, 2021 16:59
<!-- <VSSDK140Install Condition="'$(VSSDK140Install)' == ''">$(MSBuildProgramFiles32)\Microsoft Visual Studio 14.0\VSSDK\</VSSDK140Install> -->
<VSSDK170Install Condition="'$(VSSDK170Install)' == ''">$(MSBuildProgramFiles32)\Microsoft Visual Studio\2019\Professional\VSSDK\</VSSDK170Install>
<VSSdkPath Condition="'$(VisualStudioVersion.Contains(`17`))'">$(ProgramFiles)\Microsoft Visual Studio\2022\VSSDK\</VSSdkPath>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is in: C:\Program Files\Microsoft Visual Studio\2022\Professional\VSSDK -- what version of VS are using?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed 2022 Professional to a custom location. (just removed "Professional" from the default path). We can set it back to default path. Couldn't find a registry or other way to get this info (now that vswhere is needed to locate VS installations.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I also briefly ran down the rabbit hole of attempting to automagically determine install location without much success. If you could change this to the default path that would be great! Once this lands I'll upload a visix installer for VS2022 as a release here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to default paths in 458bcd4

@UnityAlex
Copy link
Collaborator

Thanks for doing this I haven't found time to do this myself! I'll be happy to upload a visix installer for 2022 once we get this working.

@UnityAlex UnityAlex merged commit b21fae7 into master Nov 29, 2021
@UnityAlex UnityAlex deleted the master-vs22 branch November 29, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants