Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix test failures on trunk with input system 1.1.1#5542

Merged
dongruoping merged 3 commits into
mainfrom
develop-fix-input-test
Sep 20, 2021
Merged

Fix test failures on trunk with input system 1.1.1#5542
dongruoping merged 3 commits into
mainfrom
develop-fix-input-test

Conversation

@dongruoping

@dongruoping dongruoping commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Proposed change(s)

Some game objects left over from input system tests is causing other tests to fail during tear down with input system package going from 1.1.0 to 1.1.1.

Clean up all the game objects in input system tests.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

JIRA

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping

Copy link
Copy Markdown
Contributor Author

Confirmed the tests passed (see commit 5eebf5a)

@maryamhonari maryamhonari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongruoping dongruoping changed the title Fix input system test errors Fix test failures on trunk with input system 1.1.1 Sep 20, 2021
@dongruoping dongruoping merged commit ee02841 into main Sep 20, 2021
@delete-merged-branch delete-merged-branch Bot deleted the develop-fix-input-test branch September 20, 2021 22:47
maryamhonari added a commit that referenced this pull request Nov 5, 2021
… to 2.0.1 verified (#5608)

* Fix test failures on trunk with input system 1.1.1 (#5542)

* Update changeLog

Co-authored-by: Ruo-Ping Dong <[email protected]>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants