Compile ProcessImportedType in IDataContractSurrogate for unityaot#1183
Merged
joshpeterson merged 1 commit intounity-masterfrom May 21, 2019
Merged
Compile ProcessImportedType in IDataContractSurrogate for unityaot#1183joshpeterson merged 1 commit intounity-masterfrom
joshpeterson merged 1 commit intounity-masterfrom
Conversation
The `IDataContractSurrogate` interface is part of the public API of .NET 4.7.1. In has a method named `ProcessImportedType`, which was not compiled into the unityaot profile. The `ProcessImportedType` method uses types `CodeTypeDeclaration` and `CodeCompileUnit` as parameters. Both of these types are pretty large, and we don't want to compile them into the unityaot profile. So in order to compile the `ProcessImportedType` method method, add empty `CodeTypeDeclaration` and `CodeCompileUnit` types in unityaot (the profile stubber will fill these in properly). This change allows the unstripped unityaot profile work correctly with IL2CPP. It is difficult for the profile stubber to handle this case, because the code in `SurrogateProviderAdapter` is in a facade assembly, which the profile stubber currently ignores.
joncham
approved these changes
May 20, 2019
mrvoorhe
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IDataContractSurrogateinterface is part of the public API of.NET 4.7.1. In has a method named
ProcessImportedType, which was notcompiled into the unityaot profile.
The
ProcessImportedTypemethod uses typesCodeTypeDeclarationandCodeCompileUnitas parameters. Both of these types are pretty large,and we don't want to compile them into the unityaot profile.
So in order to compile the
ProcessImportedTypemethod method, addempty
CodeTypeDeclarationandCodeCompileUnittypes in unityaot (theprofile stubber will fill these in properly). This change allows the
unstripped unityaot profile work correctly with IL2CPP.
It is difficult for the profile stubber to handle this case, because
the code in
SurrogateProviderAdapteris in a facade assembly, whichthe profile stubber currently ignores.