feat: histogram metric #767
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds a new Histogram metric type to the impact-metrics system, following the same patterns as existing Counter and Gauge metrics.
Key Features
Important files
Start review by reading tests to understand how histograms work in prometheus.
Discussion points
The backend will need to support batch histogram restoration from collected bucket data, which prom-client doesn't natively support, so we'll likely need to build custom logic to reconstruct prom-client histograms from our bucket counts. I still think it's better than recording millions of samples and then calling observe million times on the server side.