feat: make http2 optional #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. |
User65k
approved these changes
Jan 17, 2025
Cargo.toml
Outdated
|
|
||
| http2 = ["hyper/http2"] | ||
| cookies = ["cookie_store"] | ||
| proxies = ["async-trait"] |
There was a problem hiding this comment.
turns out that the feature proxies also needs tokio/io-util which was pulled by hyper/http2.
Can you please add it here and also as a dev-dependency? (its also used in tests within lib.rs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some space constrain devices such as embedded device we need to make the binary smallest as possible. This PR make http2 as feature for allowing reduce binary size some hundreds kB