feat: harden enterprise server setup #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| verify_prerequisites(){ | ||
| local required_cmds=(curl wget tar systemctl) | ||
| for bin in "${required_cmds[@]}"; do | ||
| command -v "$bin" >/dev/null 2>&1 || die "Required command '$bin' not found. Install it and retry." | ||
| done |
There was a problem hiding this comment.
Do not require curl/wget before installing dependencies
The new verify_prerequisites exits if curl, wget, tar, or systemctl are not available, but these tools are installed later by install_common. On a fresh Debian/CentOS image that does not include curl or wget by default, the script now aborts before it ever reaches the installation phase, whereas the previous version would bootstrap successfully. Consider dropping this check or running it after install_common so that the script can still bring a minimal system up to a usable state.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f8ffc21664832cac9b13823bd8f2ee