Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Throw for greedy RegisterFileConverter<object> #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Jul 6, 2026
+31 −0
Merged

Throw for greedy RegisterFileConverter<object> #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/StaticSettingsTests/RegisterFileConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
public class RegisterFileConverterTests :
BaseTest
{
[Fact]
public void ObjectThrows()
{
var exception = Assert.Throws<Exception>(
() => VerifierSettings.RegisterFileConverter<object>(
(_, _) => new(null, "txt", "value")));
Assert.Contains("too greedy", exception.Message);
}

[Fact]
public void ObjectAsyncThrows()
{
var exception = Assert.Throws<Exception>(
() => VerifierSettings.RegisterFileConverter<object>(
(_, _) => Task.FromResult<ConversionResult>(new(null, "txt", "value"))));
Assert.Contains("too greedy", exception.Message);
}
}
10 changes: 10 additions & 0 deletions src/Verify/Splitters/Settings_Typed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public static void RegisterFileConverter<T>(
CanConvert<T>? canConvert = null)
{
InnerVerifier.ThrowIfVerifyHasBeenRun();
ThrowIfObjectConverter<T>();
RegisterFileConverter(
(target, context) => Task.FromResult(conversion(target, context)),
canConvert);
Expand All @@ -36,10 +37,19 @@ public static void RegisterFileConverter<T>(
CanConvert<T>? canConvert = null)
{
InnerVerifier.ThrowIfVerifyHasBeenRun();
ThrowIfObjectConverter<T>();
var converter = new TypeConverter((target, context) => conversion((T) target, context), DefaultCanConvert(canConvert));
typedConverters.Add(converter);
}

static void ThrowIfObjectConverter<T>()
{
if (typeof(T) == typeof(object))
{
throw new("RegisterFileConverter<object> is too greedy since object matches all verified values. Instead use a more specific type, or use the non-generic RegisterFileConverter overload that takes an explicit `canConvert`.");
}
}

public static void RegisterFileConverter(
Conversion conversion,
CanConvert canConvert)
Expand Down
Loading