controller/operator/factory: run PollUntilContextTimeout with immediate flag #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te flag When `immediate` flag is unset this function waits for `interval` first and only afterwards runs the function the first time. This commit changes all function calls to use `immediate` true to make it run sooner
* fix broken deploy reconcile test * mention changes at changelog.md Signed-off-by: f41gh7 <[email protected]>
Collaborator
|
Thanks for contribution! |
Collaborator
|
Feature was included into v0.62.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
immediateflag is unset, this function waits forintervalfirst and only afterward runs the function the first time. This commit changes all function calls to useimmediatetrue to make it run sooner.With tracing the effects of these flags is most obvious.
Before:
reconcile.waitDeploymentReadydoesn't do anything for a second and then runsclient.GetAfter:
Now
reconcile.waitDeploymentReadytakes 25 nanoseconds and runsclient.GetimmediatelyUnfortunately I didn't get a chance to test this PR properly, as it affects a lot of areas in operators, but I can't think of a reason why would it cause regressions.