reconcile/service: properly handle loadbalancerClass field change #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, operator produced runtime error: ``` cannot reconcile additional service for CRD: Service "CRD-NAME" is invalid: spec.loadBalancerClass: Invalid value: "null": may not change once set ``` This commit adds `Service` re-creation on field change. It's expected that `Service` `IP` will be changed. And it may interrupt communication with application.
Collaborator
Author
|
The bugfix was included into v0.63.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, operator produced runtime error:
This commit adds
Servicere-creation on field change. It's expectedthat
ServiceIPwill be changed. And it may interrupt communication with application.