fix: If any signature is valid, the file is properly signed#1936
Merged
Conversation
Member
|
Do you have some test case for this? Some file that mixes invalid and valid signatures? |
Contributor
Author
|
Yes,some file first signature timestamps are out of date,but the second one is valid.The last signature taken by the old code is not as expected. It also does not match the current comment of the variable ”signature_valid“ |
Member
|
It would be great if we can add a test case for this, that's why I was asking for file. |
plusvic
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If any signature will be valid, pe file is correctly signed