Feat/seedless refresh token #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: himanshuchawla009 <[email protected]>
…Controller.ts Co-authored-by: himanshuchawla009 <[email protected]>
…Controller.ts Co-authored-by: himanshuchawla009 <[email protected]>
…Controller.ts Co-authored-by: himanshuchawla009 <[email protected]>
…Controller.ts Co-authored-by: himanshuchawla009 <[email protected]>
…Mask/core into feat/seedless-onboarding-controller
Member
himanshuchawla009
left a comment
There was a problem hiding this comment.
- Skip lock usage comment should improved
- Incorrect comment on skip lock, currently it mentions about aggregate verifier.
- rename
doAuthenticatetodoAuthenticateWithNodes - Incorrect jsdocs for passwordd field on
createToprfKeyAndBackupSeedPhrasefunction refreshTokenerror is incorrect inassertIsAuthenticatedUserassertIsAuthenticatedUserdoesn’t check for expiry of node auth tokens.- I think we should refresh tokens proactively meaning we should first check if node auth tokens are expired on client side thn thn refresh instead of just relying on 401 from server, 401 should be the fallback
assertIsAuthenticatedUsershould be moved insidewithControllerLockcallback so that it can prevent doing multiple refresh tokens when token expires parallely for more thn 1 call.
| * The refresh token used to refresh expired nodeAuthTokens. | ||
| * This is temporarily stored in state during authentication and then persisted in the vault. | ||
| */ | ||
| refreshToken?: string; |
Member
There was a problem hiding this comment.
i think we can't persist refresh token in the vault as it can be used even before wallet is unlocked, only revokeToken should be in vault
Member
Author
There was a problem hiding this comment.
@himanshuchawla009 oh this one is in state, not the vault
the vault data type is in
/**
* The structure of the data which is serialized and stored in the vault.
*/
export type VaultData = {
Member
There was a problem hiding this comment.
ah need to fix the code comment, comment says its persisted in vault
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add refresh token and revoke refresh token handling to SeedlessOnboardingController
References
Changelog
Checklist