Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add customElements.getName method#13053

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rniwa:fix255778
Apr 22, 2023
Merged

Add customElements.getName method#13053
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rniwa:fix255778

Conversation

@rniwa
Copy link
Member

@rniwa rniwa commented Apr 21, 2023 •
edited by webkit-early-warning-system
Loading

e2748d7

Add customElements.getName method
https://bugs.webkit.org/show_bug.cgi?id=255778

Reviewed by Alexey Shvayka and Chris Dumez.

Implement whatwg/html#9195 with test cases added in
web-platform-tests/wpt#39640

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html:
* Source/WebCore/dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::getName): Added.
* Source/WebCore/dom/CustomElementRegistry.h:
* Source/WebCore/dom/CustomElementRegistry.idl:

Canonical link: https://commits.webkit.org/263281@main

f21fc1a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner April 21, 2023 22:42
@rniwa rniwa self-assigned this Apr 21, 2023
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash cf869e1)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
⏳ 🛠 watch ✅ 🛠 jsc-mips
⏳ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 21, 2023
shvaikalesh
shvaikalesh reviewed Apr 21, 2023
View reviewed changes
shvaikalesh
shvaikalesh reviewed Apr 21, 2023
View reviewed changes
Source/WebCore/dom/CustomElementRegistry.idl Outdated
Copy link
Member

@shvaikalesh shvaikalesh Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Custom] DOMString? getName(any constructor);
[Custom] DOMString? getName(Function constructor);

Copy link
Member Author

@rniwa rniwa Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... this results in an error like this:

Could NOT find IDL file for interface "Function"!
Could NOT find IDL file for interface "Function"!

@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e16454a)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
⏳ 🛠 watch
✅ 🛠 watch-sim

cdumez
cdumez approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 253cb16)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
⏳ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a7e0b6b)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
rniwa
rniwa commented Apr 22, 2023
View reviewed changes
Source/WebCore/dom/CustomElementRegistry.cpp Outdated
Copy link
Member Author

@rniwa rniwa Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use the name "interface" on Windows. It's why WinCairo is failing to build.
This comes up every time I touch this file. It's annoying as hell...

@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 22, 2023 •
edited
Loading

EWS run on current version of this PR (hash f21fc1a)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 22, 2023
@rniwa rniwa added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 22, 2023
@rniwa
Add customElements.getName method
e2748d7 
https://bugs.webkit.org/show_bug.cgi?id=255778

Reviewed by Alexey Shvayka and Chris Dumez.

Implement whatwg/html#9195 with test cases added in
web-platform-tests/wpt#39640.

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html:
* Source/WebCore/dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::getName): Added.
* Source/WebCore/dom/CustomElementRegistry.h:
* Source/WebCore/dom/CustomElementRegistry.idl:

Canonical link: https://commits.webkit.org/263281@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Apr 22, 2023

Committed 263281@main (e2748d7): https://commits.webkit.org/263281@main

Reviewed commits have been landed. Closing PR #13053 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e2748d7 into WebKit:main Apr 22, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 22, 2023
@rniwa rniwa deleted the fix255778 branch April 22, 2023 19:28
This was referenced Apr 23, 2023
Merged
Closed
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shvaikalesh shvaikalesh shvaikalesh approved these changes

@cdumez cdumez cdumez approved these changes

Assignees

@rniwa rniwa

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @cdumez @shvaikalesh @webkit-ews-buildbot