Thanks to visit codestin.com
Credit goes to github.com

Skip to content

expose <address> and <fieldset> as aria group #20751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webkit-commit-queue merged 1 commit into from
Nov 21, 2023
Merged

expose <address> and <fieldset> as aria group #20751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ x
x
x

FAIL el-address assert_equals: <address data-testname="el-address" data-expectedrole="group" class="ex">x</address> expected "group" but got ""
PASS el-address
PASS el-article
PASS el-blockquote
PASS el-button
Expand All @@ -64,7 +64,7 @@ FAIL el-details assert_equals: <details data-testname="el-details" data-expected
FAIL el-dfn assert_equals: <dfn data-testname="el-dfn" data-expectedrole="term" class="ex">x</dfn> expected "term" but got "definition"
FAIL el-dt assert_equals: <dt data-testname="el-dt" data-expectedrole="term" class="ex">x</dt> expected "term" but got ""
FAIL el-em assert_equals: <em data-testname="el-em" data-expectedrole="emphasis" class="ex">x</em> expected "emphasis" but got ""
FAIL el-fieldset assert_equals: <fieldset data-testname="el-fieldset" data-expectedrole="group" class="ex"><legend>x</legend><input></fieldset> expected "group" but got ""
PASS el-fieldset
PASS el-figure
PASS el-form
PASS el-h1
Expand Down
4 changes: 2 additions & 2 deletions LayoutTests/platform/ios/imported/w3c/web-platform-tests/html-aam/roles-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ x
x
x

FAIL el-address assert_equals: <address data-testname="el-address" data-expectedrole="group" class="ex">x</address> expected "group" but got ""
PASS el-address
PASS el-article
PASS el-blockquote
PASS el-button
Expand All @@ -64,7 +64,7 @@ FAIL el-details assert_equals: <details data-testname="el-details" data-expected
FAIL el-dfn assert_equals: <dfn data-testname="el-dfn" data-expectedrole="term" class="ex">x</dfn> expected "term" but got "definition"
FAIL el-dt assert_equals: <dt data-testname="el-dt" data-expectedrole="term" class="ex">x</dt> expected "term" but got ""
FAIL el-em assert_equals: <em data-testname="el-em" data-expectedrole="emphasis" class="ex">x</em> expected "emphasis" but got ""
FAIL el-fieldset assert_equals: <fieldset data-testname="el-fieldset" data-expectedrole="group" class="ex"><legend>x</legend><input></fieldset> expected "group" but got ""
PASS el-fieldset
PASS el-figure
PASS el-form
PASS el-h1
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ abbr[title]

address
AXRole: AXGroup
AXSubrole:
AXSubrole: AXApplicationGroup
AXRoleDescription: group

article
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ abbr[title]

address
AXRole: AXGroup
AXSubrole:
AXSubrole: AXApplicationGroup
AXRoleDescription: group

article
Expand Down
4 changes: 2 additions & 2 deletions Source/WebCore/accessibility/AccessibilityNodeObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ AccessibilityRole AccessibilityNodeObject::determineAccessibilityRoleFromNode(Tr
if (node()->hasTagName(menuTag) || node()->hasTagName(olTag) || node()->hasTagName(ulTag))
return AccessibilityRole::List;
if (node()->hasTagName(fieldsetTag))
return AccessibilityRole::Group;
return AccessibilityRole::ApplicationGroup;
if (node()->hasTagName(figureTag))
return AccessibilityRole::Figure;
if (node()->hasTagName(pTag))
Expand Down Expand Up @@ -467,7 +467,7 @@ AccessibilityRole AccessibilityNodeObject::determineAccessibilityRoleFromNode(Tr
if (node()->hasTagName(sectionTag))
return hasAttribute(aria_labelAttr) || hasAttribute(aria_labelledbyAttr) ? AccessibilityRole::LandmarkRegion : AccessibilityRole::TextGroup;
if (node()->hasTagName(addressTag))
return AccessibilityRole::Group;
return AccessibilityRole::ApplicationGroup;
if (node()->hasTagName(blockquoteTag))
return AccessibilityRole::Blockquote;
if (node()->hasTagName(captionTag) || node()->hasTagName(figcaptionTag))
Expand Down