Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Include <chrono> for chrono_literals. #37058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Dec 2, 2024
Merged

Include <chrono> for chrono_literals. #37058

webkit-commit-queue merged 1 commit into from
Dec 2, 2024

Conversation

@StephanTLavavej
Copy link
Contributor

@StephanTLavavej StephanTLavavej commented Nov 22, 2024 •
edited by webkit-early-warning-system
Loading

cf74749

Include <chrono> for chrono_literals.

Reviewed by Fujii Hironori.

The C++ Standard requires the <chrono> header to be included before
using the user-defined literals in the chrono_literals namespace.
WorkQueue.cpp was incorrectly assuming that including <thread>
would drag in these chrono UDLs, but this assumption will be broken
by an upcoming update of Microsoft Visual C++ (expected to ship in
VS 2022 17.13). Including <chrono> is portable and backwards-compatible.

No tests added - this is purely a compile-time fix, and if the code
builds, it's good.

* WebKit/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Include <chrono>.

Canonical link: https://commits.webkit.org/287203@main

fbef012

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 22, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 0ec6b02)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 23, 2024
@Constellation
Copy link
Member

Constellation commented Nov 24, 2024

Hi! Can you follow to the instructions in https://webkit.org/contributing-code/ ? WebKit requires specific format in commit message.

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 24, 2024 •
edited
Loading

EWS run on current version of this PR (hash fbef012)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@StephanTLavavej
Copy link
Contributor Author

StephanTLavavej commented Nov 24, 2024

I've amended my commit message to try to follow the conventions.

@fujii fujii added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 2, 2024
@StephanTLavavej @fujii
Include <chrono> for chrono_literals.
cf74749 
Reviewed by Fujii Hironori.

The C++ Standard requires the <chrono> header to be included before
using the user-defined literals in the chrono_literals namespace.
WorkQueue.cpp was incorrectly assuming that including <thread>
would drag in these chrono UDLs, but this assumption will be broken
by an upcoming update of Microsoft Visual C++ (expected to ship in
VS 2022 17.13). Including <chrono> is portable and backwards-compatible.

No tests added - this is purely a compile-time fix, and if the code
builds, it's good.

* WebKit/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Include <chrono>.

Canonical link: https://commits.webkit.org/287203@main
@webkit-commit-queue webkit-commit-queue changed the title Include <chrono> for chrono_literals Include <chrono> for chrono_literals. Dec 2, 2024
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Dec 2, 2024

Committed 287203@main (cf74749): https://commits.webkit.org/287203@main

Reviewed commits have been landed. Closing PR #37058 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cf74749 into WebKit:main Dec 2, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 2, 2024
@StephanTLavavej StephanTLavavej deleted the include-chrono branch December 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujii fujii fujii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StephanTLavavej @webkit-early-warning-system @Constellation @webkit-commit-queue @fujii @webkit-ews-buildbot