Project Management Automation: Derive due date from previous milestone#20851
Merged
Conversation
|
Size Change: +8.87 kB (1%) Total Size: 825 kB
ℹ️ View Unchanged
|
17bee20 to
3003d67
Compare
gziolo
approved these changes
Apr 16, 2020
gziolo
left a comment
Member
There was a problem hiding this comment.
It makes sense to approach it this way 👍
0677682 to
d58b673
Compare
d58b673 to
af7f5ef
Compare
aduth
commented
May 1, 2020
Member
Author
|
Logging looks good at the merge automation: https://github.com/WordPress/gutenberg/runs/637302498 Notably, regarding #20851 (comment), I marked the Gutenberg 8.0 milestone as closed immediately prior to merging this pull request, and it was still able to discover it and compute the correct next due date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by (merges to): #20850Supersedes #20189
This pull request seeks to update the existing
addMilestonetask to avoid using constants for reference versions upon which the next milestone due date is calculated. As seen in #20189, these constants are fragile due to exceptions in release cycle. The changes here propose to use the previous milestone due date as the reference date. To support this, included are additional improvements to ensure that the milestone results from the GitHub REST API can be correctly paginated.This currently merges to the branch of #20850; the intention being to use the types-checking as a developer experience improvement for working with the Octokit REST API library, since the addition of types enables auto-completion in supported IDEs.
Testing Instructions:
Existing tests have been updated: