Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Components: Start adding types progressively#26066

Merged
sirreal merged 5 commits into
masterfrom
try/start-typing-components
Oct 14, 2020
Merged

Components: Start adding types progressively#26066
sirreal merged 5 commits into
masterfrom
try/start-typing-components

Conversation

@sirreal

@sirreal sirreal commented Oct 13, 2020 •
edited by ockham
Loading

Copy link
Copy Markdown
Member

Description

Add types to the Dashicon leaf component in packages/components/.

Part of #18838.

How has this been tested?

npm run build:package-types

Verify that this passes, and that types are being built in packages/components/build-types/dashicon/.

Screenshots

N/A

Types of changes

Add types

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sirreal sirreal mentioned this pull request Oct 13, 2020
Closed
75 tasks
@github-actions

github-actions Bot commented Oct 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.19 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 667 B 0 B
build/block-directory/index.js 8.56 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 144 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 685 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.3 kB 0 B
build/edit-post/style.css 6.29 kB 0 B
build/edit-site/index.js 21.3 kB 0 B
build/edit-site/style-rtl.css 3.86 kB 0 B
build/edit-site/style.css 3.86 kB 0 B
build/edit-widgets/index.js 21.3 kB 0 B
build/edit-widgets/style-rtl.css 2.97 kB 0 B
build/edit-widgets/style.css 2.97 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

ockham
ockham reviewed Oct 13, 2020
View reviewed changes
Comment thread packages/components/src/dashicon/index.js Outdated
@ockham ockham mentioned this pull request Oct 13, 2020
Merged
6 tasks
@ZebulanStanphill ZebulanStanphill added [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality labels Oct 13, 2020
ZebulanStanphill
ZebulanStanphill reviewed Oct 13, 2020
View reviewed changes
Comment thread packages/components/tsconfig.json Outdated
@ockham ockham force-pushed the try/start-typing-components branch from 251fc7e to 29cd1b0 Compare October 13, 2020 18:41
@ockham ockham marked this pull request as ready for review October 13, 2020 19:06
@ockham ockham force-pushed the try/start-typing-components branch from 29cd1b0 to 51bc244 Compare October 13, 2020 19:33
ockham
ockham approved these changes Oct 13, 2020
View reviewed changes

@ockham ockham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI -- I had some trouble trying to restart them in bulk).

@sirreal sirreal force-pushed the try/start-typing-components branch from 51bc244 to 7c390e8 Compare October 13, 2020 21:36
@sirreal sirreal mentioned this pull request Oct 13, 2020
Merged
6 tasks
@sirreal sirreal force-pushed the try/start-typing-components branch 2 times, most recently from ef7e069 to f69171b Compare October 14, 2020 08:29
@sirreal sirreal force-pushed the try/start-typing-components branch from f69171b to 3f14b00 Compare October 14, 2020 09:17
@sirreal sirreal merged commit 25977ff into master Oct 14, 2020
@sirreal sirreal deleted the try/start-typing-components branch October 14, 2020 14:33
@github-actions github-actions Bot added this to the Gutenberg 9.2 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill left review comments
@ockham ockham ockham approved these changes
@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten
@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@sirreal @ockham @ZebulanStanphill