Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated: Type package#26429

Merged
sirreal merged 4 commits into
masterfrom
update/type-deprecated
Nov 13, 2020
Merged

Deprecated: Type package#26429
sirreal merged 4 commits into
masterfrom
update/type-deprecated

Conversation

@sirreal

@sirreal sirreal commented Oct 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Add types to the deprecated package.

How has this been tested?

Tests pass.

Screenshots

Types of changes

New feature: Add type declarations to the deprecated package.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sirreal sirreal added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 23, 2020
@sirreal sirreal self-assigned this Oct 23, 2020
@sirreal sirreal added [Package] Deprecated packages/deprecated npm Packages Related to npm packages labels Oct 23, 2020
@github-actions

github-actions Bot commented Oct 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.19 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/index.js 8.71 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 133 kB 0 B
build/block-editor/style-rtl.css 11.3 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/editor-rtl.css 8.91 kB 0 B
build/block-library/editor.css 8.91 kB 0 B
build/block-library/index.js 147 kB 0 B
build/block-library/style-rtl.css 8.1 kB 0 B
build/block-library/style.css 8.1 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48 kB 0 B
build/components/index.js 171 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.9 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 821 B 0 B
build/data/index.js 8.74 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.92 kB 0 B
build/edit-navigation/index.js 11.1 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.43 kB 0 B
build/edit-post/style.css 6.42 kB 0 B
build/edit-site/index.js 23.2 kB 0 B
build/edit-site/style-rtl.css 3.98 kB 0 B
build/edit-site/style.css 3.98 kB 0 B
build/edit-widgets/index.js 26.3 kB 0 B
build/edit-widgets/style-rtl.css 3.16 kB 0 B
build/edit-widgets/style.css 3.16 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/index.js 42.5 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 3.05 kB 0 B
build/rich-text/index.js 13.3 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.05 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@sirreal sirreal force-pushed the update/type-deprecated branch 3 times, most recently from eca675f to 903bd46 Compare October 30, 2020 10:41
sirreal
sirreal commented Oct 30, 2020
View reviewed changes
Comment thread packages/deprecated/README.md
_Type_

- `Object`
- `Record<string,(|undefined)>`

@sirreal sirreal Oct 30, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't picked up properly.

@gziolo gziolo Nov 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, is it logged somewhere?

@sirreal sirreal Nov 13, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now 🙂

#26971

@sirreal sirreal mentioned this pull request Oct 31, 2020
Closed
75 tasks
@sirreal sirreal force-pushed the update/type-deprecated branch from 903bd46 to 13ae524 Compare November 13, 2020 16:57
@sirreal sirreal marked this pull request as ready for review November 13, 2020 16:58
@sirreal sirreal mentioned this pull request Nov 13, 2020
Closed
6 tasks
gziolo
gziolo approved these changes Nov 13, 2020
View reviewed changes

@gziolo gziolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@sirreal sirreal mentioned this pull request Nov 13, 2020
Closed
@sirreal sirreal merged commit 0545e7d into master Nov 13, 2020
@sirreal sirreal deleted the update/type-deprecated branch November 13, 2020 21:39
@github-actions github-actions Bot added this to the Gutenberg 9.4 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes
@sarayourfriend sarayourfriend Awaiting requested review from sarayourfriend
@ockham ockham Awaiting requested review from ockham
@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten
@ellatrix ellatrix Awaiting requested review from ellatrix
@nerrad nerrad Awaiting requested review from nerrad
@ntwb ntwb Awaiting requested review from ntwb

Assignees

@sirreal sirreal

Labels

npm Packages Related to npm packages [Package] Deprecated packages/deprecated [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 9.4

Development

Successfully merging this pull request may close these issues.

2 participants

@sirreal @gziolo