Compose: Add types (progressively)#27344
Closed
sirreal wants to merge 27 commits into
Closed
Conversation
b4afa52 to
9238527
Compare
This was referenced Jan 14, 2021
Closed
This seems like it should return strings but it may return a number
9238527 to
fcebfd6
Compare
This was referenced Feb 22, 2021
Closed
sarayourfriend
left a comment
Contributor
There was a problem hiding this comment.
Given that we now have native TypeScript support... should we just be re-writing these in TypeScript? It's probably a lot easier to do iteratively (one PR per file/couple of files) and would yield better results in the end.
Comment on lines
+98
to
+109
| /** | ||
| * @template R | ||
| * @typedef {import('react').ReducerState<R>} ReducerState | ||
| */ | ||
| /** | ||
| * @template R | ||
| * @typedef {import('react').ReducerAction<R>} ReducerAction | ||
| */ | ||
| /** | ||
| * @template D | ||
| * @typedef {import('react').Dispatch<D>} Dispatch | ||
| */ |
Contributor
There was a problem hiding this comment.
Do we need these types?
Co-authored-by: sarayourfriend <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of #18838
How has this been tested?
Screenshots
Types of changes
Checklist: