api-fetch: Type the rest of the package#30161
Merged
Merged
Conversation
|
Size Change: +370 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
sarayourfriend
commented
Mar 24, 2021
09e6e5f to
8292d0d
Compare
sarayourfriend
commented
Mar 24, 2021
tyxla
reviewed
Mar 25, 2021
| } ); | ||
| return ( | ||
| window | ||
| // @ts-ignore |
Member
There was a problem hiding this comment.
Were we going to type this one, too?
Contributor
Author
There was a problem hiding this comment.
No, I wasn't sure where these came from or how to type them effectively without having to declare the types for all the things that TS is doing a good job of inferring. How does the nonceMiddleware end up on apiFetch?
Member
There was a problem hiding this comment.
I see. Well, this is a mess 😉 Should it have been a part of the nonce middleware instead? It's definitely something we can fix in another PR anyway.
Member
There was a problem hiding this comment.
Just saw this. nonceMiddleware and nonceEndpoint are being used in Core:
It definitely can use some improvements though 😅 .
| "declarationDir": "build-types" | ||
| }, | ||
| "references": [ | ||
| { "path": "../i18n" }, |
tyxla
approved these changes
Mar 25, 2021
tyxla
left a comment
Member
There was a problem hiding this comment.
I've left some nitty suggestions and comments, but I believe this looks great already ❤️
| } ); | ||
| return ( | ||
| window | ||
| // @ts-ignore |
Member
There was a problem hiding this comment.
I see. Well, this is a mess 😉 Should it have been a part of the nonce middleware instead? It's definitely something we can fix in another PR anyway.
This was referenced Mar 25, 2021
gziolo
pushed a commit
that referenced
this pull request
Mar 26, 2021
* api-fetch: Type the rest of the package * Update CHANGELOG * Undo spread operator * Fall back to window.location * Use location.href instead of toString and fix comments
Member
|
I cherry-picked this PR to the Gutenberg plugin 10.3 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This depends on #30150. It types the rest of
api-fetch.Unfortunately because
fetch-all-middlewaredepends onindex.jsit's not possible to do them separately. Luckily there are very few runtime changes in this PR (only two really).How has this been tested?
Type checks and unit tests pass
Types of changes
New feature! Publicly exposed type definitions for the package 🎉
Checklist: