dom: Add types to clean-node-list#30412
Merged
Merged
Conversation
|
Size Change: +12 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
sarayourfriend
commented
Mar 31, 2021
| if ( | ||
| schema.hasOwnProperty( tag ) && | ||
| ( ! schema[ tag ].isMatch || schema[ tag ].isMatch( node ) ) | ||
| ( ! schema[ tag ].isMatch || schema[ tag ].isMatch?.( node ) ) |
Contributor
Author
There was a problem hiding this comment.
! schema[ tag ].isMatch || doesn't all the way refine isMatch's presence. There might be a better way to do this but I'm not sure about it 🤔
Member
There was a problem hiding this comment.
I think the optional chaining will do a good job here 👍
sarayourfriend
commented
Mar 31, 2021
| ( ! schema[ tag ].isMatch || schema[ tag ].isMatch?.( node ) ) | ||
| ) { | ||
| if ( node.nodeType === node.ELEMENT_NODE ) { | ||
| if ( isElement( node ) ) { |
Contributor
Author
There was a problem hiding this comment.
This is a type guard that does the same thing as the previous check but also refines the type to Element from Node.
sarayourfriend
commented
Mar 31, 2021
| // We cannot use \s since it includes special spaces which we want | ||
| // to preserve. | ||
| return /^[ \f\n\r\t\v\u00a0]*$/.test( element.nodeValue ); | ||
| return /^[ \f\n\r\t\v\u00a0]*$/.test( element.nodeValue || '' ); |
Contributor
Author
There was a problem hiding this comment.
nodeValue could be null so this defaults it to ''.
75 tasks
sarayourfriend
commented
Apr 1, 2021
tyxla
reviewed
Apr 1, 2021
Contributor
Author
|
@tyxla Can I get a review when you have a chance? 🙂 |
tyxla
approved these changes
Apr 6, 2021
tyxla
left a comment
Member
There was a problem hiding this comment.
Nothing more to add here. Looks great from my perspective 🚢
| if ( | ||
| schema.hasOwnProperty( tag ) && | ||
| ( ! schema[ tag ].isMatch || schema[ tag ].isMatch( node ) ) | ||
| ( ! schema[ tag ].isMatch || schema[ tag ].isMatch?.( node ) ) |
Member
There was a problem hiding this comment.
I think the optional chaining will do a good job here 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds types to
clean-node-list. There are a few runtime changes, I've annotated each with the reason why they're necessary.Part of #18838
How has this been tested?
Type checks pass and e2e and unit tests pass
Types of changes
Non-breaking changes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).