[TypeScript] Simplify core-data types#42238
Closed
adamziel wants to merge 5 commits into
Closed
Conversation
|
Size Change: -122 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Superseded by #43515 and the related work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR prepares core-data selector types for the newly supported useSelect's autocompletion.
Technically, it renames selectors.ts to selectors.js and removes the "TypeScript lookup table" magic.
Why?
The current types heavily rely on generics, and generics don't play well with useSelect which is a blocker for bringing autocompletion support for core-data selectors.
Therefore, I'd like to take a step back and start again, smaller. Here's a hypothetical progression to illustrate what I mean:
Testing Instructions
cc @dmsnell @sarayourfriend