Codestin Search App

ramonjd · 2026-02-18T03:29:14Z

Summary

This PR attempts to sync selection across:

list view
canvas (inside patterns)
block inspector content fields
When editing a pattern, clicking a list-view-enabled block (e.g. Buttons, Social Links) in the content list switches the inspector to the List View tab
Selecting a different block without list view support (e.g. Heading) left the tab stuck on List View because the section block clientId never changes, so the existing tab reset logic never fired
Adds a selector that detects when the selected block is a content item that doesn't navigate to List View, and an effect that switches back to the Content tab on a false → true transition

Testing Instructions

Create a pattern containing a Heading, a Buttons block (with at least one Button child), and a Paragraph
Select the pattern to enter content-only editing
In the inspector Content tab, click the Buttons item — the tab should switch to List View
Click the Heading block in the canvas — the tab should switch back to Content
Manually click the List View tab icon — it should stay on List View (no regression)

Test plan

Verify switching from list-view block to non-list-view block resets the tab
Verify manually clicking the List View tab still works
Verify clicking between two list-view blocks works correctly
Verify initial tab selection and requestedTab are not affected

Before

Kapture.2026-04-16.at.14.38.32.mp4

After

Kapture.2026-04-16.at.14.37.31.mp4

Navigation block (inside a template part)

Kapture.2026-02-20.at.16.09.29.mp4

github-actions · 2026-02-18T03:41:23Z

Size Change: +302 B (0%)

Total Size: 8.46 MB

📦 View Changed

Filename	Size	Change
`build/scripts/block-editor/index.min.js`	380 kB	+302 B (+0.08%)

_{compressed-size-action}

github-actions · 2026-02-18T03:54:02Z

Flaky tests detected in 31e087a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24491967120
📝 Reported issues:

[Flaky Test] Items list is reachable via TAB #61701 in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js
[Flaky Test] post title and content are editable and blocks can be inserted #76524 in /test/e2e/specs/editor/various/post-content-focus-mode.spec.js
[Flaky Test] should show correct homepage actions based on current homepage or posts page #77385 in /test/e2e/specs/site-editor/homepage-settings.spec.js

talldan · 2026-02-18T04:36:37Z

This works well. I thought that maybe it'd also select the list view tab when selecting one of the blocks that's shown there, but it doesn't. So it's a lot more minimal than I expected, and that might be a good thing this close to beta. 😄

I tested the 'Edit navigation' button changes from Navigation: select list view tab on contentOnly. Alternative with explicit solution, and that still works. However, if you click 'Edit navigation' and then select a different block that doesn't have list view support, the List View tab still remains open, so the behavior feels a bit inconsistent there.

ramonjd · 2026-02-18T04:50:34Z

However, if you click 'Edit navigation' and then select a different block that doesn't have list view support, the List View tab still remains open, so the behavior feels a bit inconsistent there

Thanks for testing. I'll take a look 👀

ramonjd · 2026-02-18T05:39:08Z

I'll keep this one simmering and see if I can crack something that's consistent. Might need more thorough testing.

Cheers!

ramonjd · 2026-02-18T06:05:23Z

I'm listing some preliminary scenarios (need validating) to handle so I can come back to test:

Content block selection while on List View → switches to Content tab

Click Buttons in content list → List View, then click Heading in canvas → Content
Click Social Links in content list → List View, then click Paragraph in canvas → Content
Click Buttons in canvas while on List View → Content (previously stayed stuck on List View)
“Edit navigation” → List View, then click Heading in canvas → Content
requestInspectorTab('list') → List View, then select any content block → Content

List child selection while on Content tab → switches to List View

Click Button 1 (child of Buttons) in the canvas while on Content → List View
Click a Social Link (child of Social Links) in the canvas while on Content → List View

Intentional List View switches are preserved (not undone by reset)

Click Buttons in content list → switchToListView sets skipNextContentResetRef → stays on List View
Click Social Links in content list → same skip mechanism → stays on List View
“Edit navigation” → requestedTab effect sets skipNextContentResetRef → stays on List View

No-op scenarios (tab stays where it is)

Click Heading while already on Content → stays on Content (same role, no transition)
Click Button 1 then Button 2 in list view → stays on List View (isListChildSelected stays true)
Click Buttons in content list then Social Links in content list → both use switchToListView, stays on List View
Manually click List View tab → stays on List View (no block change triggers the effect)
Manually click Settings/Styles tab → not affected (effects only switch between Content and List View)

ramonjd · 2026-02-19T01:35:55Z

+				}
+				const parentName = getBlockName( parentId );
+				if (
+					parentName === 'core/navigation' ||


Tech debt alert. There's probably a very good reason why the navigation block doesn't support supports: { listView: true }. I need to remind myself why

It was the first block to implement the List View inspector UX, and because of that it has its own custom implementation rather than using the proper block support.

A couple of parts work slightly differently on the nav block List View like the appender and settings menu, so it hasn't been possible to make the block use the block support.

github-actions · 2026-02-25T05:16:53Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <[email protected]>
Co-authored-by: talldan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ramonjd · 2026-03-06T00:24:02Z

However, if you click 'Edit navigation' and then select a different block that doesn't have list view support, the List View tab still remains open, so the behavior feels a bit inconsistent there.

Sorry I forgot to reply to this. I just retested according to the steps in #75578

Kapture.2026-03-06.at.11.22.51.mp4

Are you still seeing the list view tab remaining open, or am I looking in the wrong place?

…t item When editing a pattern, clicking a list-view-enabled block (e.g. Button) in the content list switches the inspector to the List View tab. Selecting a different block without list view support (e.g. Heading) left the tab stuck on List View because the section block clientId never changes, so the existing tab reset logic never fired. Add a selector that detects when the selected block is a content item that doesn't navigate to List View, and an effect that switches back to the Content tab in that case. Co-Authored-By: Claude Opus 4.6 <[email protected]>

The clientId-based reset for the "Edit navigation" case was not visibly different from the existing fix. Reverting to keep only the shouldResetToContentTab transition logic. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Replace the previous approach that only reset the tab for non-list-view blocks with a simpler one that resets to Content whenever any content block is selected while on List View. This handles the case where clicking a list-view-enabled block (e.g. Buttons) via the canvas should also return to the Content tab. A skipNextContentResetRef prevents the reset from firing when switchToListView or requestInspectorTab intentionally opened List View for that same block (content list click-through and "Edit navigation"). Co-Authored-By: Claude Opus 4.6 <[email protected]>

When a child of a list-view-enabled content block is selected (e.g. clicking Button 1 inside a Buttons block in the canvas), auto-switch to the List View tab. This makes the inspector tab behavior consistent regardless of whether the child was selected via the list view panel or directly in the canvas. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Set hasUserSelectionRef to true (not false) when programmatically switching to List View for a list child. This prevents the auto-select effect from immediately resetting back to the first tab (Content). Co-Authored-By: Claude Opus 4.6 <[email protected]>

When auto-switching to List View for a selected list child, also call setOpenListViewPanel with the parent block's clientId and increment the expand revision. This ensures the correct panel expands and the selected child block is visible in the list view. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Remove redundant prev-ref guards from inspector tab effects

…nested test

…n in the state selection. This change ensures that the anchor element is re-queried after the PrivateListView remounts, improving the accuracy of the displayed content in the list view.

This commit introduces a new test suite for the pattern inspector tabs in the block editor. It includes tests for resetting the inspector tab when selecting non-list-view content blocks, maintaining the List View tab selection, and auto-switching to the List View when interacting with list children. These tests ensure consistent behavior of the inspector UI across different interaction scenarios.

github-actions Bot added the [Package] Block editor /packages/block-editor label Feb 18, 2026

ramonjd self-assigned this Feb 18, 2026

ramonjd added the [Type] Enhancement A suggestion for improvement. label Feb 18, 2026

ramonjd mentioned this pull request Feb 18, 2026

Gallery: Add list view block support #75407

Merged

ramonjd force-pushed the update/pattern-inspector-content-focus branch from 1a3b66f to 8e0fb02 Compare February 18, 2026 04:57

ramonjd commented Feb 19, 2026

View reviewed changes

talldan reviewed Feb 19, 2026

View reviewed changes

Comment thread packages/block-editor/src/store/private-selectors.js Outdated

ramonjd force-pushed the update/pattern-inspector-content-focus branch 3 times, most recently from 0b7ef83 to f98d3e1 Compare February 25, 2026 05:11

ramonjd marked this pull request as ready for review February 25, 2026 05:16

ramonjd requested a review from ellatrix as a code owner February 25, 2026 05:16

ramonjd force-pushed the update/pattern-inspector-content-focus branch from f98d3e1 to dc35086 Compare March 6, 2026 00:27

ramonjd requested review from MaggieCabrera and tellthemachines March 6, 2026 00:27

ramonjd force-pushed the update/pattern-inspector-content-focus branch from dc35086 to a44940f Compare March 10, 2026 06:40

ramonjd force-pushed the update/pattern-inspector-content-focus branch from a44940f to 31e087a Compare April 16, 2026 04:23

ramonjd force-pushed the update/pattern-inspector-content-focus branch from 31e087a to 6cbb4b2 Compare May 11, 2026 02:34

ramonjd force-pushed the update/pattern-inspector-content-focus branch from 6cbb4b2 to 1bd4937 Compare May 25, 2026 03:40

ramonjd and others added 3 commits June 10, 2026 16:16

Revert clientId change effect extension

67c6e54

The clientId-based reset for the "Edit navigation" case was not visibly different from the existing fix. Reverting to keep only the shouldResetToContentTab transition logic. Co-Authored-By: Claude Opus 4.6 <[email protected]>

ramonjd and others added 8 commits June 10, 2026 16:16

Extract getListViewChildParentId to private store selector

1878eaa

Remove redundant prev-ref guards from inspector tab effects

Fix getListViewChildParentId docstring: "nearest" → "top-level"; add …

03bbb58

…nested test

Updated the ListViewContentPopover component to include expandRevisio…

95e2623

…n in the state selection. This change ensures that the anchor element is re-queried after the PrivateListView remounts, improving the accuracy of the displayed content in the list view.

Merge useSelecdts

e2c07ad

ramonjd force-pushed the update/pattern-inspector-content-focus branch from 1bd4937 to 169e1d2 Compare June 10, 2026 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block Editor: Reset inspector tab when selecting non-list-view content item#75656

Block Editor: Reset inspector tab when selecting non-list-view content item#75656
ramonjd wants to merge 11 commits into
trunkfrom
update/pattern-inspector-content-focus

ramonjd commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

talldan commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Uh oh!

ramonjd Feb 19, 2026

Uh oh!

talldan Feb 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

ramonjd commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ramonjd commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related

Testing Instructions

Test plan

Before

After

Uh oh!

github-actions Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talldan commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Uh oh!

ramonjd commented Feb 18, 2026

Content block selection while on List View → switches to Content tab

List child selection while on Content tab → switches to List View

Intentional List View switches are preserved (not undone by reset)

No-op scenarios (tab stays where it is)

Uh oh!

ramonjd Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

talldan Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

ramonjd commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ramonjd commented Feb 18, 2026 •

edited

Loading

github-actions Bot commented Feb 18, 2026 •

edited

Loading

github-actions Bot commented Feb 18, 2026 •

edited

Loading