Rename Dominant Color module to Dominant Color images#705
Merged
Conversation
joemcgill
approved these changes
Apr 6, 2023
joemcgill
left a comment
Member
There was a problem hiding this comment.
This is only changing inline doc references, from what I can tell, but seems fine to me, assuming that is the intent.
Member
Author
|
@joemcgill Yes, the only relevant change outside of inline docs is the module name in the module header - which is still in an inline doc, but will be displayed to users, that is the most relevant change in this PR. |
mukeshpanchal27
approved these changes
Apr 7, 2023
mukeshpanchal27
left a comment
Member
There was a problem hiding this comment.
Thanks @felixarntz, The changes look good to me.
Do we need to update module slug images/dominant-color to images/dominant-color-images as we already implemented legacy_module_slugs feature in plugin
Member
Author
|
@mukeshpanchal27 Thanks, that's a great idea! I'll implement a follow up PR. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #640, however can be merged independently.
Relevant technical choices
Dominant Colormodule should be renamed toDominant Color Images, since thedominant-colorslug is already taken by another plugin in the WordPress plugin repository. It was decided to go with that name in the linked discussion.readme.txtand themodule-i18n.phpfiles, which is not necessary as that will automatically happen as part of the release preparation scripts (see https://make.wordpress.org/performance/handbook/performance-lab/releasing-the-plugin/#preparing-the-release).Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.