This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Add templates and theme.json changes for "personal blog"#103
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
commented
Aug 21, 2024
carolinan
commented
Aug 21, 2024
carolinan
commented
Aug 21, 2024
Change the layout type of the query loop to default. This fixes a problem where full width blocks did not use the correct width in the archives.
- Change the inner div in the post navigation to a nav. - Add an aria label that says "Post navigation" - Move the section to a pattern.
This comment was marked as outdated.
This comment was marked as outdated.
Add block style variation for the pill shaped post terms. Clean up the unwanted font size on the group that wraps the tags. Remove the separator from the tags.
Contributor
Author
|
I am merging this for the sake of speed and making testing easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the templates and patterns for the "personal blog".
Figma link
For #40
Testing Instructions
On your WordPress test installation, set these reading settings:
Then create some mixed content.
Two pages, one with and without a featured image.
A couple of posts, with and without tags and featured images, with titles of different lengths.
There needs to be enough posts to trigger the pagination on single posts and archives.
Add a default width, wide width, and full width group block with a background color to one post and page, to test
that the widths work correctly in single view and archives.
View all the templates both in the Site Editor and the front, and compare them to the Figma design.
Home
Archive
Search
Single
Page
Index -To view this template on the front you first need to delete or rename the home template in the theme folder.
Test on different browser window sizes.
Screenshots
Small previews:
Single post:
Archive:
