Codestin Search App

shivamdev-lgtm · 2025-12-02T07:25:02Z

Trac: https://core.trac.wordpress.org/ticket/64256

github-actions · 2025-12-02T07:25:11Z

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

github-actions · 2025-12-02T07:25:13Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props whiteshadow01, westonruter, audrasjb, mindctrl.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-12-02T07:40:08Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

westonruter · 2025-12-02T08:00:21Z


 	$xml = <<<EOD
 <error>
-    <code>{$parsed_args['code']}</code>


Looks like this change needs to be reverted?

westonruter · 2025-12-02T08:00:34Z

+	// Also ensure HTTP 500 if response is already set to 500 (from fatal error handler).
+	if ( $is_critical_error || 500 === $parsed_args['response'] ) {
+		$parsed_args['response'] = 500;
+		if ( function_exists( 'http_response_code' ) ) {


When would this function ever not exist?

removed the check

mindctrl · 2025-12-02T14:46:42Z

+	// Also ensure HTTP 500 if response is already set to 500 (from fatal error handler).
+	if ( $is_critical_error || 500 === $parsed_args['response'] ) {
+		$parsed_args['response'] = 500;
+		if ( function_exists( 'http_response_code' ) ) {


It seems weird to set $parsed_args['response'] = 500; if it's already set that way, as per the check on the line above.

westonruter

See comments.

mindctrl · 2025-12-05T16:18:15Z


+	// Ensure HTTP 500 status code for critical errors, even if headers were already sent.
+	$is_critical_error = false;
+	if ( function_exists( 'is_wp_error' ) && is_wp_error( $message ) ) {


Is this function_exists check necessary? It's defined in load.php, which is loaded before this file.

References:

wordpress-develop/src/wp-settings.php

Line 37 in 2929fe2

require ABSPATH . WPINC . '/load.php';

wordpress-develop/src/wp-settings.php

Line 117 in 2929fe2

require ABSPATH . WPINC . '/functions.php';

removed the check

mindctrl · 2025-12-09T14:57:02Z

+			$error_code        = $message->get_error_code();
+			$is_critical_error = ( 'internal_server_error' === $error_code );


No need to save the error code as a variable since it's only used once.

Suggested change

$error_code = $message->get_error_code();

$is_critical_error = ( 'internal_server_error' === $error_code );

$is_critical_error = ( 'internal_server_error' === $message->get_error_code() );

westonruter · 2025-12-10T16:00:56Z


+	// Ensure HTTP 500 status code for critical errors, even if headers were already sent.
+	$is_critical_error = false;
+	if ( is_wp_error( $message ) ) {


All of the function_exists() checks above for __() and esc_url() make me think that actually we should maybe not assume that is_wp_error() exists. In any case, it isn't necessary:

Suggested change

if ( is_wp_error( $message ) ) {

if ( $message instanceof WP_Error ) {

Copilot

Pull request overview

Updates the default wp_die() HTML handler to force an HTTP 500 status code when handling “critical”/internal server error scenarios.

Changes:

Adds “critical error” detection in _default_wp_die_handler() based on code/response (and attempted WP_Error) inputs.
Forces the computed wp_die() response to 500 and calls http_response_code(500) for critical errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T21:34:49Z

+	if ( $message instanceof WP_Error ) {
+			$is_critical_error = $message->get_error_code();
+	} elseif ( 'internal_server_error' === $parsed_args['code'] || 500 === $parsed_args['response'] ) {
+			$is_critical_error = true;
+	}


$message instanceof WP_Error can fatally error if WP_Error is not loaded yet (wp-settings.php loads wp-includes/functions.php before wp-includes/class-wp-error.php). Also, _wp_die_process_input() typically converts a WP_Error message into a string before this handler runs, so this branch is usually unreachable. Consider removing the instanceof check and relying on $parsed_args['code']/$parsed_args['response'], or guard it with class_exists( 'WP_Error' ) before using instanceof.

This is not entirely correct. If WP_Error does not exist, no fatal error occurs. See https://3v4l.org/uCFvc#veol

https://github.com/shivamdev-lgtm/wordpress-develop/blob/756e1d67fd188e35f6b6b04c8df61a0a25d420e5/src/wp-includes/functions.php#L4317-L4318 Since WP_Error is getting converted here, removing the redundant check and simplifying the logic a bit

Copilot · 2026-01-29T21:34:49Z

+
+	if ( $is_critical_error ) {
+		$parsed_args['response'] = 500;
+		http_response_code( 500 );


http_response_code( 500 ) is executed unconditionally when $is_critical_error is true. If headers have already been sent, this can emit a PHP warning (and still cannot change the response code). To avoid noisy warnings/regressions, only call this when ! headers_sent() (or drop it and rely on the existing status_header() call inside the ! headers_sent() block).

Suggested change

http_response_code( 500 );

if ( ! headers_sent() ) {

http_response_code( 500 );

}

mindctrl · 2026-02-04T14:11:36Z

@shivamdev-lgtm are you able to address the remaining review comments?

shivamdev-lgtm · 2026-02-04T14:12:49Z

Yes I'll take it up tomorrow @mindctrl

Co-authored-by: Copilot <[email protected]>

shivamdev-lgtm · 2026-02-05T08:13:25Z

@mindctrl I have fixed the rest of the comments. Please take a look

audrasjb · 2026-02-18T21:29:57Z

 		$message  .= "\n<p><a href='javascript:history.back()'>$back_text</a></p>";
 	}

+	// Ensure HTTP 500 status code for critical errors.


Maybe replace "Ensure" with "Enforce"?

fix: send 500 response code on critical errors

3280d5b

westonruter reviewed Dec 2, 2025

View reviewed changes

mindctrl reviewed Dec 2, 2025

View reviewed changes

westonruter requested changes Dec 2, 2025

View reviewed changes

fix: pr reviews

a246dd0

shivamdev-lgtm requested a review from westonruter December 4, 2025 05:53

mindctrl reviewed Dec 5, 2025

View reviewed changes

fix: remove redundant function_exists check

de14cfe

mindctrl reviewed Dec 10, 2025

View reviewed changes

westonruter reviewed Dec 10, 2025

View reviewed changes

shivamdev-lgtm and others added 2 commits December 11, 2025 12:02

fix: more PR reviews

d19b7a3

Merge branch 'trunk' into fix/resp-code-500

c1b1556

westonruter requested a review from Copilot January 29, 2026 21:29

Copilot started reviewing on behalf of westonruter January 29, 2026 21:29 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

shivamdev-lgtm and others added 3 commits February 5, 2026 13:17

Update src/wp-includes/functions.php

4391385

Co-authored-by: Copilot <[email protected]>

chore: remove redundant WP_Error check

756e1d6

fix: do not send response code if header already sent

ece64eb

Merge branch 'trunk' into fix/resp-code-500

47cb55a

audrasjb reviewed Feb 18, 2026

View reviewed changes

		$error_code = $message->get_error_code();
		$is_critical_error = ( 'internal_server_error' === $error_code );

	if ( is_wp_error( $message ) ) {
	if ( $message instanceof WP_Error ) {

Conversation

shivamdev-lgtm commented Dec 2, 2025

Uh oh!

github-actions Bot commented Dec 2, 2025

Uh oh!

github-actions Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 2, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

westonruter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mindctrl commented Feb 4, 2026

Uh oh!

shivamdev-lgtm commented Feb 4, 2026

Uh oh!

shivamdev-lgtm commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Dec 2, 2025 •

edited

Loading