Codestin Search App

sirreal · 2025-12-04T18:32:15Z

Trac ticket: https://core.trac.wordpress.org/ticket/64360

The enqueue_block_assets action is used to add scripts and styles in the block editor's iframe.

It should be possible to add script modules to the block editor's iframe as well.

See:

_wp_get_iframed_editor_assets and its documentation.
The WP_Script_Modules class.
The block editor Iframe component in Gutenberg.
This will likely require a new method or exposing more of the script modules internal data so that a specific WP_Script_Modules instance can be used for the iframed assets. See #60597.

Requires Gutenberg changes to the block editor. See WordPress/gutenberg#73765.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-12-04T18:47:20Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

sirreal · 2025-12-11T13:00:44Z

-		'scripts' => $scripts,
+		'styles'         => $styles,
+		'scripts'        => $scripts,
+		'script_modules' => $script_modules,


Script modules print the script tags, but also print HTML for the @wordpress/a11y module if it's enqueued. That probably needs to be injected into the editor as well?

wordpress-develop/src/wp-includes/class-wp-script-modules.php

Lines 937 to 951 in 63b3a8f

/**

* @access private This is only intended to be called by the registered actions.

*

* @since 6.7.0

*/

public function print_a11y_script_module_html() {

if ( ! $this->a11y_available ) {

return;

}

echo '<div style="position:absolute;margin:-1px;padding:0;height:1px;width:1px;overflow:hidden;clip-path:inset(50%);border:0;word-wrap:normal !important;">'

. '<p id="a11y-speak-intro-text" class="a11y-speak-intro-text" hidden>' . esc_html__( 'Notifications' ) . '</p>'

. '<div id="a11y-speak-assertive" class="a11y-speak-region" aria-live="assertive" aria-relevant="additions text" aria-atomic="true"></div>'

. '<div id="a11y-speak-polite" class="a11y-speak-region" aria-live="polite" aria-relevant="additions text" aria-atomic="true"></div>'

. '</div>';

}

Since print_a11y_script_module_html runs at wp_footer, yes, it seems this will need to be captured separately above with more output buffering.

The very selective nature of picking and choosing what gets captured to be injected into the editor iframe, however, gives me pause about how well the editor will replicate the frontend in which themes and plugins could be adding other arbitrary markup to wp_head and wp_footer.

Good point. A specific action for the editor iframe analogous to wp_head to capture arbitrary HTML for inclusion may be best here. Then this would just run the action instead if calling select methods.

Co-authored-by: Weston Ruter <[email protected]>

This value is set and accessed in the printing flow and should be reset

The editor package prints styles and scripts sequentially. Provide HTML as styles to ensure its printed in legacy editor packages.

…dules

sirreal mentioned this pull request Dec 4, 2025

Block Editor: Allow iframed script modules WordPress/gutenberg#73765

Draft

westonruter reviewed Dec 9, 2025

View reviewed changes

Comment thread src/wp-includes/class-wp-script-modules.php Outdated

westonruter reviewed Dec 9, 2025

View reviewed changes

Comment thread src/wp-includes/class-wp-script-modules.php Outdated

westonruter reviewed Dec 9, 2025

View reviewed changes

Comment thread src/wp-includes/block-editor.php

sirreal commented Dec 11, 2025

View reviewed changes

sirreal and others added 6 commits December 12, 2025 15:05

Capture modules enqueued on enqueue_block_assets

20a1a39

Change instance cloning logic

c4612ec

Co-authored-by: Weston Ruter <[email protected]>

Set a11y_available = false on clone

08fca13

This value is set and accessed in the printing flow and should be reset

Document new method

54214b4

Try dedicated action

e29ce4b

Restore styles to array

28305f9

The editor package prints styles and scripts sequentially. Provide HTML as styles to ensure its printed in legacy editor packages.

sirreal force-pushed the 64360/block-editor-iframe-include-script-modules branch from 17136e4 to 28305f9 Compare December 12, 2025 14:05

sirreal added 3 commits December 12, 2025 15:09

Update return type

3bef1bb

Fix ob_end/ob_get error

804b431

Merge branch 'trunk' into 64360/block-editor-iframe-include-script-mo…

e27c966

…dules

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block Editor: Enqueue script modules via enqueue_block_assets action#10597

Block Editor: Enqueue script modules via enqueue_block_assets action#10597
sirreal wants to merge 9 commits into
WordPress:trunkfrom
sirreal:64360/block-editor-iframe-include-script-modules

sirreal commented Dec 4, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sirreal Dec 11, 2025

Uh oh!

westonruter Dec 11, 2025

Uh oh!

sirreal Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/**
	* @access private This is only intended to be called by the registered actions.
	*
	* @since 6.7.0
	*/
	public function print_a11y_script_module_html() {
	if ( ! $this->a11y_available ) {
	return;
	}
	echo '<div style="position:absolute;margin:-1px;padding:0;height:1px;width:1px;overflow:hidden;clip-path:inset(50%);border:0;word-wrap:normal !important;">'
	. '<p id="a11y-speak-intro-text" class="a11y-speak-intro-text" hidden>' . esc_html__( 'Notifications' ) . '</p>'
	. '<div id="a11y-speak-assertive" class="a11y-speak-region" aria-live="assertive" aria-relevant="additions text" aria-atomic="true"></div>'
	. '<div id="a11y-speak-polite" class="a11y-speak-region" aria-live="polite" aria-relevant="additions text" aria-atomic="true"></div>'
	. '</div>';
	}

Conversation

sirreal commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 4, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sirreal Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

westonruter Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

sirreal Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sirreal commented Dec 4, 2025 •

edited

Loading