Switch to generating UUID4 components with wp_rand()#10694
Conversation
…lly cryptographically secure.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Have you verified the bitwise operations (| 0x4000, | 0x8000)?
There was a problem hiding this comment.
Pull request overview
This pull request improves the security of UUID4 generation in WordPress by replacing the non-cryptographically secure mt_rand() function with wp_rand(), which uses a cryptographically secure pseudo-random number generator (CSPRNG) when available.
Changes:
- Replaced all 8 calls to
mt_rand()withwp_rand()in thewp_generate_uuid4()function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prevents a fatal if this function is called before pluggable functions have been loaded. Props peterwilsoncc.
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks Jorbin, this looks good to me presuming the unit tests pass.
Trac ticket: Core-59239