#64896 Correct the documentation for the plugin property in the wp_get_connectors() array#12440
#64896 Correct the documentation for the plugin property in the wp_get_connectors() array#12440johnbillion wants to merge 1 commit into
plugin property in the wp_get_connectors() array#12440Conversation
…nnectors()` array.
plugin property in the wp_get_connectors() arrayplugin property in the wp_get_connectors() array
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
left a comment
There was a problem hiding this comment.
Thank you for the PR. I would appreciate it if a similar change could be applied on the Gutenberg side after this PR is merged.
| * @type callable $is_active Callback to determine whether the plugin is active. Receives no arguments and must return bool. | ||
| * Defaults to `__return_true`. |
There was a problem hiding this comment.
| * @type callable $is_active Callback to determine whether the plugin is active. Receives no arguments and must return bool. | |
| * Defaults to `__return_true`. | |
| * @type callable $is_active Optional callback to determine whether the plugin | |
| * is active. Receives no arguments and must return bool. | |
| * Defaults to `__return_true`. |
| * @type string $file Optional. The plugin's main file path relative to the plugins | ||
| * directory (e.g. 'my-plugin/my-plugin.php' or 'hello.php'). | ||
| * @type callable $is_active Callback to determine whether the plugin is active. Receives no arguments and must return bool. | ||
| * Defaults to `__return_true`. |
There was a problem hiding this comment.
| * Defaults to `__return_true`. | |
| * @type callable $is_active Optional callback to determine whether the plugin | |
| * is active. Receives no arguments and must return bool. | |
| * Defaults to `__return_true`. |
Nit: I think this also needs to be aligned with the connector registry documentation. This property is also effectively optional.
Follow-up to https://core.trac.wordpress.org/changeset/62332
Trac ticket: https://core.trac.wordpress.org/ticket/64896