Fix validation of array of fields + adjust tests#2656
Closed
felipeelia wants to merge 3 commits into
Closed
Conversation
peterwilsoncc
requested changes
May 1, 2022
peterwilsoncc
left a comment
Contributor
There was a problem hiding this comment.
When reviewing the tests, I noticed a typo in the query include[space] rather than include.
This results in all users been returned each time, instead of just the one admin you are aiming for. That's why you needed to check for user 1 rather than the user ID self::$admin_ids[0]
To force the right check, I'd recommend setting the included user to 1
In the data provider
- set the email to
WP_TESTS_EMAIL - set the URL to
wp_guess_url()
Other details for the admin user are hard coded within the test suite.
Member
Author
|
Good catch @peterwilsoncc, didn't notice the |
peterwilsoncc
approved these changes
May 1, 2022
Contributor
|
Merged in https://core.trac.wordpress.org/changeset/53327, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the adjustments outlined by @peterwilsoncc
Trac ticket: https://core.trac.wordpress.org/ticket/53177
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.