#56041 site health full page cache#2894
Closed
manuelRod wants to merge 16 commits into
Closed
Conversation
swissspidy
reviewed
Jul 12, 2022
swissspidy
reviewed
Jul 12, 2022
swissspidy
reviewed
Jul 12, 2022
3 tasks
Clorith
reviewed
Aug 7, 2022
Clorith
left a comment
Member
There was a problem hiding this comment.
I had a look over here, and had some feedback, and questions about approaches that I've left in-line.
Author
|
@Clorith @swissspidy @spacedmonkey feedback applied.
|
felixarntz
reviewed
Aug 12, 2022
felixarntz
left a comment
Member
There was a problem hiding this comment.
@manuelRod This looks solid to me. Other than the existing feedback, I mostly have some nit-pick comments, which are worth addressing to polish the implementation.
felixarntz
reviewed
Aug 25, 2022
felixarntz
left a comment
Member
There was a problem hiding this comment.
@manuelRod Just some final nit-picks here, based on the previous comments.
Author
|
@felixarntz thanks for the feedback. I've replaces all "page caching" appearances with "page cache". |
# Conflicts: # src/wp-admin/includes/class-wp-site-health.php # tests/phpunit/tests/site-health.php
Author
|
@felixarntz I've updated the PR with trunk and solved the conflicts. All good! |
felixarntz
approved these changes
Aug 31, 2022
felixarntz
left a comment
Member
There was a problem hiding this comment.
Excellent work @manuelRod!
Member
|
Committed in https://core.trac.wordpress.org/changeset/54043. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing Full Page Cache check into Site Health
Trac ticket: #56041
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.