Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add_image_size: enable controlling additional_mime_types #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adamsilverstein wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

add_image_size: enable controlling additional_mime_types #3217

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ad515
add_image_size: enable controlling additional_mime_types
adamsilverstein Sep 8, 2022
6cc49d2
Add sizes to defaults
adamsilverstein Sep 8, 2022
b4460f2
missing space
adamsilverstein Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions src/wp-includes/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,23 +278,25 @@ function image_downsize( $id, $size = 'medium' ) {
*
* @global array $_wp_additional_image_sizes Associative array of additional image sizes.
*
* @param string $name Image size identifier.
* @param int $width Optional. Image width in pixels. Default 0.
* @param int $height Optional. Image height in pixels. Default 0.
* @param bool|array $crop Optional. Image cropping behavior. If false, the image will be scaled (default),
* If true, image will be cropped to the specified dimensions using center positions.
* If an array, the image will be cropped using the array to specify the crop location.
* Array values must be in the format: array( x_crop_position, y_crop_position ) where:
* - x_crop_position accepts: 'left', 'center', or 'right'.
* - y_crop_position accepts: 'top', 'center', or 'bottom'.
* @param string $name Image size identifier.
* @param int $width Optional. Image width in pixels. Default 0.
* @param int $height Optional. Image height in pixels. Default 0.
* @param bool|array $crop Optional. Image cropping behavior. If false, the image will be scaled (default),
* If true, image will be cropped to the specified dimensions using center positions.
* If an array, the image will be cropped using the array to specify the crop location.
* Array values must be in the format: array( x_crop_position, y_crop_position ) where:
* - x_crop_position accepts: 'left', 'center', or 'right'.
* - y_crop_position accepts: 'top', 'center', or 'bottom'.
* @param bool $additional_mime_types Optional. Whether to output mapped mapping. Default null.
*/
function add_image_size( $name, $width = 0, $height = 0, $crop = false ) {
function add_image_size( $name, $width = 0, $height = 0, $crop = false, $additional_mime_types = null ) {
global $_wp_additional_image_sizes;

$_wp_additional_image_sizes[ $name ] = array(
'width' => absint( $width ),
'height' => absint( $height ),
'crop' => $crop,
'width' => absint( $width ),
'height' => absint( $height ),
'crop' => $crop,
'additional_mime_types' => ! empty( $additional_mime_types ),
);
}

Expand Down Expand Up @@ -3918,6 +3920,8 @@ function _wp_image_editor_choose( $args = array() ) {
* @return array The adjusted default output mapping.
*/
function wp_default_image_output_mapping( $output_mapping, $filename, $mime_type, $size_name = '' ) {
global $__wp_additional_image_sizes;

// If size name is specified, check whether the size supports additional MIME types like WebP.
if ( $size_name ) {
// Include only the core sizes that do not rely on add_image_size(). Additional image sizes are opt-in.
Expand All @@ -3929,6 +3933,13 @@ function wp_default_image_output_mapping( $output_mapping, $filename, $mime_type
'post-thumbnail' => true,
);

// Add any custom sizes that have secondarly mime output enabled.
foreach ( $__wp_additional_image_sizes as $size => $size_data ) {
if ( ! empty( $size_data['additional_mime_types'] ) ) {
$enabled_sizes[ $size ] = true;
}
}

/**
* Filters the sizes that support secondary mime type output. Developers can use this
* to control the generation of additional mime type sub-sized images.
Expand Down