Fix the_block_template_skip_link() to print style in head#5472
Closed
westonruter wants to merge 5 commits into
Closed
Fix the_block_template_skip_link() to print style in head#5472westonruter wants to merge 5 commits into
westonruter wants to merge 5 commits into
Conversation
sabernhardt
reviewed
Oct 12, 2023
| <?php | ||
| $skip_link_script = wp_remove_surrounding_empty_script_tags( ob_get_clean() ); | ||
| $script_handle = 'wp-block-template-skip-link'; | ||
| wp_register_script( $script_handle, false, array(), false, array( 'in_footer' => 'true' ) ); |
spacedmonkey
approved these changes
Oct 13, 2023
spacedmonkey
left a comment
Member
There was a problem hiding this comment.
This looks good. Marking as ready to commit.
Member
Author
|
Committed in r56932. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59505
Commit Message
Script Loader: Enqueue inline style for block template skip link in head instead of footer.
wp_enqueue_block_template_skip_link()to replacethe_block_template_skip_link(). Add towp_enqueue_scriptsaction instead ofwp_footer.the_block_template_skip_link()from 6.3 and move todeprecated.php.the_block_template_skip_linkfromwp_footeraction.Follow-up to [56682] and [56687].
Props sabernhardt, plugindevs, westonruter, spacedmonkey.
Fixes #59505.
See #58775.
See #58664.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.