Open
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Contributor
Author
|
hi there, how's going with this one? |
lib/src/state_machine.dart
Outdated
| /// bool, true if this state is None, | ||
| /// false otherwise | ||
| bool get isNone { | ||
| return name == _NONE_STATE_NAME; |
Contributor
There was a problem hiding this comment.
Instead of adding isNone to the API for every State instance, could we add a static field to represent the none state and use that? Then the isInitial getter below could be:
bool get isInitial => from == State.none
Contributor
Author
There was a problem hiding this comment.
should looks better now
Contributor
|
@lidio601 if you could run dartfmt and commit the changes, we should be able to get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I'm listening to a state
onEnterevent to perform some database changes when a transition happens.I noticed that this event was triggered also just after the
stm.start(initialState);line.To cope with this event and ignore this first initial transition I checked the source code and found that this event has a stub
__none__state.So in my code I ended up with this:
I think this is not the best approach as I'm relying on some internal representation.
That's why I'm exposing this
State.isNonegetter.Changes
State.isNonegetter addedStateChange.isInitialRelease Notes
Exposed
State.isNoneandStateChange.isInitialto distinguish initial state change events.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: