More readable regex in keyword.py#160
Merged
Merged
Conversation
added 2 commits
April 11, 2019 11:40
KevinHock
approved these changes
Apr 11, 2019
Collaborator
KevinHock
left a comment
There was a problem hiding this comment.
This may be my favorite PR yet, 😍 , thank you so much for making my code better!
Collaborator
|
(Not merging yet due to merge conflict, but code looks great to me.) |
Contributor
Author
|
Thanks @KevinHock, happy to contribute to such a great project 👍, fixed the conflicts |
Collaborator
|
re: Keyword detector, if you've used it, I'm curious to hear your thoughts about it. I was planning on making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the regex by using named string replacement