Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle "leapfrog" case for --audit#47

Merged
domanchi merged 1 commit into
masterfrom
bug-fix-handle-leapfrog-audit-case
Jun 28, 2018
Merged

Handle "leapfrog" case for --audit#47
domanchi merged 1 commit into
masterfrom
bug-fix-handle-leapfrog-audit-case

Conversation

@domanchi
Copy link
Copy Markdown
Contributor

Bug

When applying an audit, to an already audited baseline, users may find themselves in a strange case: through a combination of skips and decisions, secrets may be overridden in the baseline accidentally.

This should not happen.

Testing

detect-secrets$ detect-secrets --audit .secrets.baseline
<User enters: "y, s, s, n" respectively>
detect-secrets$ detect-secrets --audit .secrets.baseline
<User enters: "y, s, y" respectively>

You would expect that the output is like the below illustration:

secretA: TRUE
secretB: TRUE
secretC: SKIP
secretD: FALSE
secretE: TRUE

However, it would have actually ended up as follows:

secretA: TRUE
secretB: TRUE
secretC: SKIP
secretE: TRUE

@domanchi domanchi requested a review from KevinHock June 28, 2018 19:49
Copy link
Copy Markdown
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domanchi domanchi merged commit 9adf255 into master Jun 28, 2018
@domanchi domanchi deleted the bug-fix-handle-leapfrog-audit-case branch June 28, 2018 20:03
jfagoagas pushed a commit to jfagoagas/detect-secrets that referenced this pull request Mar 14, 2026
Add usage for reporting functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants