Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Continuous Integration via Github Action#506

Merged
jpdakran merged 21 commits into
masterfrom
dakranj_add_ci
Feb 2, 2022
Merged

Add Continuous Integration via Github Action#506
jpdakran merged 21 commits into
masterfrom
dakranj_add_ci

Conversation

@jpdakran
Copy link
Copy Markdown
Member

  • Add continuous integration via github actions

@jpdakran jpdakran marked this pull request as draft January 25, 2022 16:42
@jpdakran
Copy link
Copy Markdown
Member Author

jpdakran commented Jan 26, 2022

This is expected behavior. The linux processes should be passing for py36-39 while the macOS should be failing for py38 & py39. This is due to the python multiprocessing upgrades in py38/39 on macOS.

Once 505 & 507 are merged - We can verify all is passing and merge this.

@jpdakran jpdakran marked this pull request as ready for review January 26, 2022 16:56
@jpdakran jpdakran marked this pull request as draft January 26, 2022 16:57
Copy link
Copy Markdown
Contributor

@domanchi domanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro Tip: You can use:

$ git commit --amend --no-edit
$ git push origin HEAD --force

to keep your git history clean. This way, you don't have many, many, many commits as you make small iterations to get CI passing.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
@jpdakran jpdakran force-pushed the dakranj_add_ci branch 7 times, most recently from 359170a to 83435ad Compare January 27, 2022 18:58
@jpdakran jpdakran force-pushed the dakranj_add_ci branch 10 times, most recently from 48baa34 to 9ae841a Compare January 27, 2022 22:05
@jpdakran jpdakran marked this pull request as ready for review January 28, 2022 14:38
@jpdakran jpdakran requested a review from calvinli February 2, 2022 20:15
Comment thread .github/workflows/ci.yml
@jpdakran jpdakran merged commit 5484c1b into master Feb 2, 2022
@calvinli
Copy link
Copy Markdown
Member

calvinli commented Feb 2, 2022

I totally forgot to mention, you should update the build status badge on README.md too :)

https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge

@jpdakran jpdakran deleted the dakranj_add_ci branch February 11, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants