add py.typed file to enable type hints for package consumers#579
Merged
Conversation
7 tasks
Contributor
Author
|
@jpdakran fixed the lint issues. Didn't expect you are checking the |
jpdakran
approved these changes
Jul 12, 2022
Member
jpdakran
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added the missing
py.typedfile. So other projects, which add the project as a library will benefit from the inline type hints. Without this file type checkers, likemypy, think the whole project is untyped. And also added theTypedclassifier to make it searchable inpypi🙂 great work by the way 🚀