You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lorenzodb1
added
false negatives
P3
When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing more
selected
The issue has been selected to be worked on.
and removed
false negatives
P3
When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing more
selected
The issue has been selected to be worked on.
labels
Sep 16, 2022
Hi @nimrodkor, thank you for your PR! A few tests seem to be failing. If you could get all of them to pass, we will include your changes in the next release, which will be in two weeks. Let me know if there's anything I can help you with.
Hey @lorenzodb1 !
Thanks for your response, highly appreciated
I looked at the failing tests on TestYAMLTransformer - and I didn't touch this part. Furthermore, the test doesn't run code related to my change - it is failing to parse the yaml itself. I tried to test it on main - and it seems to still fail.
Can you verify the main branch is not failing on this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #608