Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve Release Process#625

Merged
jpdakran merged 2 commits into
masterfrom
dakranj-improve-release-process
Oct 4, 2022
Merged

Improve Release Process#625
jpdakran merged 2 commits into
masterfrom
dakranj-improve-release-process

Conversation

@jpdakran
Copy link
Copy Markdown
Member

@jpdakran jpdakran commented Oct 4, 2022

Problem:

  • When releasing detect-secrets - different deployers may get different results depending on env setup
  • Mainly revolving around if they are using a local copy of detect-secrets or not
  • When deploying we perform a commit - therefore we run pre-commit hook detect-secrets. Since in the commit we just updated the .secrets.baseline to a new version. If the installed version of detect-secrets is different - the hook will fail.

Solution:

  • When installing dependencies in the deploy process. Install a local copy of detect-secrets so there are no differences in .secrets.baseline upgraded version and old hook version.

@jpdakran jpdakran requested a review from lorenzodb1 October 4, 2022 19:28
@jpdakran jpdakran merged commit a293056 into master Oct 4, 2022
@lorenzodb1 lorenzodb1 deleted the dakranj-improve-release-process branch October 4, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants