More performant BasicAuth plugin#80
Merged
Merged
Conversation
Contributor
|
Nice one @domanchi! |
jfagoagas
pushed a commit
to jfagoagas/detect-secrets
that referenced
this pull request
Mar 14, 2026
Don't publish to separate images repositories depending on OS, instead tag the detect-secrets image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This should make the BasicAuth plugin much more performant, and fixes #79 and #77.
Testing
It actually finishes this time! Furthermore, I modified the large file by inserting a secret that I'd expect it to find, and it finds it as well.
Rationale
We're already doing
BASIC_AUTH_REGEX.findall(line)which will run the regex on all non-overlapping matches of the pattern in the string. This means that we can ignore the prefix catch-all expression (.*?) because we don't care about that, and we can let the python library handle it for us.