Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve 'Unable to open baseline file' message#91

Merged
KevinHock merged 2 commits into
masterfrom
improve_unable_to_open_baseline_msg
Oct 30, 2018
Merged

Improve 'Unable to open baseline file' message#91
KevinHock merged 2 commits into
masterfrom
improve_unable_to_open_baseline_msg

Conversation

@KevinHock
Copy link
Copy Markdown
Collaborator

fix --import->--update comment,
bump to 0.10.5,
hardcode flake8==3.5.0

@KevinHock KevinHock requested a review from domanchi October 26, 2018 18:40
Copy link
Copy Markdown
Contributor

@domanchi domanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix n ship!

Comment thread detect_secrets/pre_commit_hook.py Outdated
'Unable to open baseline file: %s.', filename,
'Unable to open baseline file: {}\n'
'Please create it via\n'
' `detect-secrets scan > .secrets.baseline`\n'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
' `detect-secrets scan > .secrets.baseline`\n'
' `detect-secrets scan > {}`\n'

Remember that we never explicitly enforce a certain baseline filename to be used.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I kind of like suggesting it but you're right it's more consistent this way.

@KevinHock KevinHock merged commit 186e31e into master Oct 30, 2018
@KevinHock KevinHock deleted the improve_unable_to_open_baseline_msg branch March 21, 2019 22:04
jfagoagas pushed a commit to jfagoagas/detect-secrets that referenced this pull request Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants