Create admin client #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyevans
reviewed
Jan 4, 2018
kafka/admin_client.py
Outdated
| timeout=timeout, | ||
| ) | ||
| return self._send_request(request) | ||
|
|
There was a problem hiding this comment.
Please check it with flake8. I am pretty sure it will complain about empty lines
kafka/admin_client.py
Outdated
| Arguments: | ||
| new_topics (list of NewTopic): A list containing new | ||
| topics to be created | ||
| validate_only (bool): True if we just want to validate the request |
There was a problem hiding this comment.
There are no validate_only param for the method
kafka/admin_client.py
Outdated
| """ Create topics on the cluster | ||
|
|
||
| Arguments: | ||
| new_topics (list of NewTopic): A list containing new |
There was a problem hiding this comment.
Please rename it to topics as param.
kafka/admin_client.py
Outdated
| topics to be created | ||
| validate_only (bool): True if we just want to validate the request | ||
| timeout (int): timeout in seconds | ||
| max_retry (int): num of times we want to retry to send a create |
ecanzonieri
reviewed
Jan 10, 2018
test/test_admin_client.py
Outdated
| )]) | ||
|
|
||
|
|
||
| class TestTopicAdmin(): |
There was a problem hiding this comment.
Can we have a unit test for delete topics?
ecanzonieri
reviewed
Jan 10, 2018
| response = admin.create_topics(topics=[topic], timeout=1) | ||
| self.assertTrue( | ||
| response[0].topic_error_codes[0][1] == 0 or | ||
| response[0].topic_error_codes[0][1] == 7 |
There was a problem hiding this comment.
Why is code 7 good? Can we add a comment?
There was a problem hiding this comment.
@ecanzonieri 7 is RequestTimedOut but we can safely assume the topic is created or will be created eventually.
for more information see this https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations
ecanzonieri
reviewed
Jan 11, 2018
test/test_admin_client.py
Outdated
| assert response == topic_response | ||
|
|
||
|
|
||
| def delete_topics( |
ecanzonieri
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont why the other branch showing ' branch upto date' so created this one. Also for the integrations test please look for my comment in the previous branch.