Refactor client to extract each endpoint into its own module #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much more manageable, I like it.
|
|
Awesome work @Dinah! |
dinahshi
added a commit
that referenced
this pull request
Dec 2, 2015
Refactor client to extract each endpoint into its own module
This was referenced Dec 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits client methods into classes by endpoint to make things more modular. Any new endpoints would go into their own file instead of making one large client file. Main client class dynamically copies the public request methods so there should be no difference in the interface. All tests passing after c72c063, then separated tests as well.
@tomelm @mittonk