Fix Base Form (1.x)#564
Merged
Merged
Conversation
Contributor
Author
|
The failing tests appear to be Registration stuff that shouldn't be in Base anyway. Obviously, this improves the usability of 1.x while 2.x is still in flux (and until key projects like ZfcUserAdmin are upgraded to the 2.x branch). |
Member
|
Can you fix the tests? :) |
Contributor
Author
|
... apparently. There's a first for everything :) Feel free to review, but this was all relocating of code (plus eliminating one duplicate test) so I'm reasonably confident that I preserved what needed preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Base constructor currently has a dependency on a function (
getRegistrationOptions) only available in child class Register. This patch moves that call into the constructor for Register so Base can be sub-classed independently.