You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 26, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr updates Node version support from 12 to 14 (latest LTS).
This pr also includes minor updates to some of the packages in order to resolve yarn bundle issues on Windows on Node 14:
@types/node 12.7.12 -> 14.14.22
protobufjs 6.8.8 -> 6.10.2
This pr also removes the need for web3-eth to be installed. web3-eth was used previously to generate a keystores.json file to used for testcases for zilliqa-js-account. The new test accounts are now generated using zilliqa-js/crypto to a new keystores_redux.json file.
Coincidentally, the removal of web3-eth also removes the requirement for a js-sha3 module which in turns removes the need for Visual Studio Build Tools to be installed on Windows when performing a yarn install.
The branch is tested with the following node LTS versions / functions and on both Windows 10 10.0.19041 Build 19041 and Ubuntu 18.04 :
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updates Node version support from 12 to 14 (latest LTS).
This pr also includes minor updates to some of the packages in order to resolve
yarn bundleissues on Windows on Node 14:@types/node12.7.12 -> 14.14.22protobufjs6.8.8 -> 6.10.2This pr also removes the need for
web3-ethto be installed.web3-ethwas used previously to generate akeystores.jsonfile to used for testcases forzilliqa-js-account. The new test accounts are now generated usingzilliqa-js/cryptoto a newkeystores_redux.jsonfile.The branch is tested with the following node LTS versions / functions and on both Windows 10 10.0.19041 Build 19041 and Ubuntu 18.04 :