Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

ESLint #313

Merged
merged 7 commits into from Jul 28, 2021
Merged

ESLint #313

merged 7 commits into from Jul 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2021

Description

This PR

  • uses ESLint intead of TSLinst has been deprecated.
  • autofixes code with prefer-const rule as a small start.
  • removes tslint rule flags.
  • adds lint and format check in CI.

Review Suggestion

Status

Implementation

  • ready for review

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners July 27, 2021 04:32
@bb111189 bb111189 requested a review from micovi July 27, 2021 04:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #313 (267a315) into dev (7ff1e4a) will increase coverage by 0.04%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #313      +/-   ##
==========================================
+ Coverage   78.97%   79.02%   +0.04%     
==========================================
  Files          45       45              
  Lines        1822     1821       -1     
  Branches      306      306              
==========================================
  Hits         1439     1439              
+ Misses        382      381       -1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/eventEmitter.ts 47.72% <ø> (ø)
packages/zilliqa-js-crypto/src/bech32.ts 90.29% <ø> (ø)
packages/zilliqa-js-subscriptions/src/ws.ts 64.96% <ø> (ø)
packages/zilliqa-js-blockchain/src/chain.ts 62.92% <85.71%> (+0.35%) ⬆️
packages/zilliqa-js-account/src/util.ts 95.23% <100.00%> (ø)
packages/zilliqa-js-account/src/wallet.ts 82.17% <100.00%> (ø)
packages/zilliqa-js-core/src/providers/http.ts 92.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff1e4a...267a315. Read the comment docs.

@bb111189 bb111189 merged commit 0f60d91 into Zilliqa:dev Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants