Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Fix Promise resolve & HeadersInit type #324

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Fix Promise resolve & HeadersInit type #324

merged 2 commits into from
Aug 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2021

Description

This PR fixes typescript errors for Promise resolve and HeadersInit.

References:

    /**
     * Creates a new Promise.
     * @param executor A callback used to initialize the promise. This callback is passed two arguments:
     * a resolve callback used to resolve the promise with a value or the result of another promise,
     * and a reject callback used to reject the promise with a provided reason or error.
     */
    new <T>(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void): Promise<T>;

    headers?: HeadersInit;
    /**
     * A cryptographic hash of the resource to be fetched by request. Sets request's integrity.
     */

Review Suggestion

Status

Implementation

  • ready for review

@ghost ghost requested review from bb111189, renlulu and teye as code owners August 6, 2021 02:01
@ghost ghost changed the title Fix/types Fix Promise resolve & HeadersInit type Aug 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #324 (1e94ca7) into dev (43cb07c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1e94ca7 differs from pull request most recent head 822c19b. Consider uploading reports for the commit 822c19b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #324   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          45       45           
  Lines        1817     1817           
  Branches      304      304           
=======================================
  Hits         1439     1439           
  Misses        377      377           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/eventEmitter.ts 47.72% <ø> (ø)
packages/zilliqa-js-core/src/net.ts 98.59% <ø> (ø)
packages/zilliqa-js-account/src/util.ts 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cb07c...822c19b. Read the comment docs.

@bb111189 bb111189 merged commit 6add1ea into dev Aug 6, 2021
@ghost ghost deleted the fix/types branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants