Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

build: add tslib as dev dependency #326

Merged
merged 1 commit into from
Aug 6, 2021
Merged

build: add tslib as dev dependency #326

merged 1 commit into from
Aug 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2021

Description

This PR adds tslib as dev dependency.

Background

In near future, we should upgrade typescript 3.2 -> 4.3 to leverage new features in v4.

However, with typescript 4.3.5, yarn bootstrap throws the following error.

packages/zilliqa-js-core/src/decorators/sign.ts:45:42 - error TS2343: This syntax requires an imported helper named '__spreadArray' which does not exist in 'tslib'. Consider upgrading your version of 'tslib'.

45       return original.call(this, signed, ...args);
                                            ~~~~~~~

Review Suggestion

Status

Implementation

  • ready for review

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 6, 2021 08:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #326 (a776dd1) into dev (43cb07c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #326   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          45       45           
  Lines        1817     1817           
  Branches      304      304           
=======================================
  Hits         1439     1439           
  Misses        377      377           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cb07c...a776dd1. Read the comment docs.

@ghost ghost changed the title build: add tslib as peer dep build: add tslib as dev dependency Aug 6, 2021
@bb111189 bb111189 merged commit 2f7f684 into dev Aug 6, 2021
@ghost ghost deleted the build/tslib-as-dev-dep branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants