Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

build: typescript v3.2 -> v3.9.10 #327

Merged
merged 2 commits into from
Aug 12, 2021
Merged

build: typescript v3.2 -> v3.9.10 #327

merged 2 commits into from
Aug 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2021

Description

This PR upgrades typescript version v3.2 -> v3.9.10

Motivation and Context

How has this been tested?

yarn bootstrap gives us the same output.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 6, 2021 10:34
@ghost ghost changed the title build: typescript v4 build: typescript v4.3 Aug 6, 2021
@ghost ghost changed the title build: typescript v4.3 build: typescript v3.2 -> v4.3.5 Aug 6, 2021
@ghost ghost requested review from teye and renlulu August 6, 2021 10:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #327 (7f0d080) into dev (6add1ea) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7f0d080 differs from pull request most recent head 6bc4056. Consider uploading reports for the commit 6bc4056 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #327      +/-   ##
==========================================
+ Coverage   79.19%   79.20%   +0.01%     
==========================================
  Files          45       45              
  Lines        1817     1818       +1     
  Branches      304      308       +4     
==========================================
+ Hits         1439     1440       +1     
  Misses        377      377              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/index.ts 100.00% <0.00%> (ø)
packages/zilliqa-js-blockchain/src/util.ts 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add1ea...6bc4056. Read the comment docs.

@teye
Copy link
Contributor

teye commented Aug 10, 2021

image

@noel-yoo , not really an issue but might want to ts-jest to make it compatible with the updated typescript. Otherwise, all tests are ok.

@ghost
Copy link
Author

ghost commented Aug 10, 2021

@teye nice catch!
To use typescript v4, a large changelist is required.
Therefore, lets' upgrade it to v3.9.10 for this PR instead of v4.3.5 to keep the changelist small as possible.

PS
I wanted optional chaining and 3.9.10 will do.

@ghost ghost changed the title build: typescript v3.2 -> v4.3.5 build: typescript v3.2 -> v3.9.10 Aug 10, 2021
@bb111189 bb111189 merged commit 17bb52e into dev Aug 12, 2021
@ghost ghost deleted the build/typescript-v4 branch August 17, 2021 11:27
@ghost ghost mentioned this pull request Sep 23, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants